Move panacea_settings.txt file creation
#1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Methods instead of clicking finish on the Mod Mnaggaer Wizard
When doing an internal copy if said file was missing it would incorrectly state the `assetFile.name` was missing whe in reality the `assetFile.Source[0].Name` was missing
|
Also Fix incorrect warning When doing an internal copy if said file was missing it would incorrectly state the assetFile.name was missing whe in reality the assetFile.Source[0].Name was missing |
Numbers are low enough it wont be off the screen for anyone but also wont be in the top right as the default. Still saves where you moved it to and will load it there in the future
|
Also Also Numbers are low enough it wont be off the screen for anyone but also wont be in the top right as the default. Still saves where you moved it to and will load it there in the future |
|
This PR has caused a regression and now Mod Manager fails to create the settings file altogether. |
|
Regression fixed as of #1141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
panacea_settings.txtcreation into the Install/Remove Panacea Methods instead of clicking finish on the Mod Manager Wizard.Also Fix incorrect warning
When doing an internal copy if said file was missing it would incorrectly state the
assetFile.namewas missing whe in reality theassetFile.Source[0].Namewas missingAlso Also
Make default postion middle of a 1920 x 1080 screen
Numbers are low enough it wont be off the screen for anyone but also wont be in the top right as the default. Still saves where you moved it to and will load it there in the future