Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): migrate renovate config #645

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 21, 2023

Mend Renovate

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.


This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Member

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably not be changing our JSON style preference on quoted property names (if we have one), but i am not planning on doing the migration manually;

checking for consistency w/ our style guide can happen once we clone and run those tasks locally;

iow, lgtm

@DerekNonGeneric
Copy link
Member

déjà vu — nothing immediately jumps out at me wrt failing ci lint (no files detected for a given plugin, not sure which exactly); same plan — will debug locally

@DerekNonGeneric DerekNonGeneric merged commit 7c6f18b into main Dec 21, 2023
3 of 4 checks passed
@DerekNonGeneric DerekNonGeneric deleted the renovate/migrate-config branch December 21, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant