Fix a small bug in canvas quads with fixed scale #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashish24
reviewed
Mar 12, 2019
| @@ -174,8 +174,8 @@ var canvas_quadFeature = function (arg) { | |||
| if (!quad.crop) { | |||
| context2d.drawImage(src, 0, 0); | |||
| } else { | |||
| var cropx = Math.min(src.w, quad.crop.x), | |||
| cropy = Math.min(src.h, quad.crop.y); | |||
| var cropx = Math.min(w, quad.crop.x), | |||
There was a problem hiding this comment.
what is the difference between src.w and w? do they point to different values?
There was a problem hiding this comment.
w is a local variable that was taken from src.width or src.videoWidth. src.w was incorrect.
This can be seen, for instance, in the deep zoom example where the lower partial tiles were not being rendered.
manthey
force-pushed
the
fix-image-fixed-scale
branch
from
5f41ef7 to
35ea761
Compare
aashish24
approved these changes
Apr 3, 2019
| @@ -174,8 +174,8 @@ var canvas_quadFeature = function (arg) { | |||
| if (!quad.crop) { | |||
| context2d.drawImage(src, 0, 0); | |||
| } else { | |||
| var cropx = Math.min(src.w, quad.crop.x), | |||
| cropy = Math.min(src.h, quad.crop.y); | |||
| var cropx = Math.min(w, quad.crop.x), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be seen, for instance, in the deep zoom example where the lower partial tiles were not being rendered.