Allow showing partial tiles on the edges of an image or map. #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tileLayer tilesMaxBounds function is defined, some tiles may be cropped. Tile cropping is implemented in the gl, canvas, and null renderers (but not d3).
| 'void main(void) {', | ||
| ' mediump vec4 color = texture2D(sampler2d, iTextureCoord);', | ||
| ' if (iTextureCoord.s > crop.s || 1.0 - iTextureCoord.t > crop.t) {', | ||
| ' return;', |
There was a problem hiding this comment.
I think discard would be a better option here.
|
@manthey so this is only going to crop towards right and bottom? What happens to the cropping towards left and top? |
Current coverage is 81.71% (diff: 100%)@@ master #606 diff @@
==========================================
Files 82 82
Lines 7442 7482 +40
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6071 6114 +43
+ Misses 1371 1368 -3
Partials 0 0
|
|
@aashish24 Yes, currently all tile sets I know of have the 0, 0 pixel within a tile, so only right and bottom cropping is necessary. All partial-tile examples I have are from medical images, and this satisfies the need there. If you have a real-world tile set which has partial tiles on the top or left, then we can add support at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tileLayer tilesMaxBounds function is defined, some tiles may be cropped. Tile cropping is implemented in the gl, canvas, and null renderers (but not d3).
This fixes issue #544.