Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several things happening here:
Remove the code that disabled get_remote_json. Now I'm not entirely sure why this was disabled in the first place - maybe just enabling it again will cause other issues?
Pass base_uri to jsonref.load - this is needed or it can't load relative files.
Remove Python 2 support. If we really want this, then I've added pathlib.Path which is 3 only.
Discussed with @kindly on call but now put as PR for all to discuss.
This is related to openownership/data-standard-sphinx-theme#4