[PATCH v9] api: dma: support source free and destination allocation features #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
There was a problem hiding this comment.
Still a few comments from internal review, we're getting there.
For better trackability, you can rebase-amend the commits with the fixes locally on your branch and then force-push to your fork-remote-branch. The changes then appear in this same pull request and GitHub can track the diff between versions (GitHub automatically updates the "[PATCH vX]" prefix when new stuff is pushed to the PR-branch).
|
Sure Tuomas, thanks for reviewing it. |
VamsiKrishnaA99
force-pushed
the
master
branch
from
adf37e0 to
ccc11ae
Compare
odpbuild
changed the title
|
Addressed V6 review comments. |
VamsiKrishnaA99
force-pushed
the
master
branch
from
ccc11ae to
e730ae3
Compare
odpbuild
changed the title
added 2 commits
February 4, 2025 10:55
This specification change details the necessary fields for advertising the source segment freeing offload for data format #ODP_DMA_FORMAT_PACKET. It also defines the required fields to enable this feature. Application can free all the source segments using odp_dma_transfer_t:seg_free field. The 'unique_src_segs' field can be used to indicate if the source packet is reused across multiple segments to avoid any double-free issues. Additionally, application can use dma transfer options field odp_dma_transfer_t:single_pool to free all source segments to a single pool, provided all segments belong to a same pool. Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
This specification change outlines the necessary fields to advertise the destination segment allocation offload feature. It also defines the required fields in odp_dma_transfer_param_t and odp_dma_seg_t to leverage this feature. When the application opts for destination packet allocation, it will receive the allocated packet details in odp_dma_result_t::dst_pkt array after the DMA completion. Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
VamsiKrishnaA99
force-pushed
the
master
branch
from
e730ae3 to
2c838f5
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.