Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v2] api: timer: require an array of timeout events in odp_timer_periodic_start() #1969

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JereLeppanen
Copy link
Collaborator

With a periodic timer, require application to provide an array of timeout events in odp_timer_periodic_start(). Add a new API function odp_timer_periodic_events(), which returns the number of events.

…start()

With a periodic timer, require application to provide an array of
timeout events in odp_timer_periodic_start(). Add a new API function
odp_timer_periodic_events(), which returns the number of events.

Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com>
@odpbuild odpbuild changed the title api: timer: require an array of timeout events in odp_timer_periodic_start() [PATCH v1] api: timer: require an array of timeout events in odp_timer_periodic_start() Dec 8, 2023
*/
odp_event_t tmo_ev;
uint32_t num_tmo_ev;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For application to be able to prepare with large enough pool of timeout events, there could be "max events per periodic timer" capability.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in v2.

Add periodic.max_tmo_events in timer capability. This is the maximum
number of timeout events per timer that may be needed.

Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com>
@odpbuild odpbuild changed the title [PATCH v1] api: timer: require an array of timeout events in odp_timer_periodic_start() [PATCH v2] api: timer: require an array of timeout events in odp_timer_periodic_start() Dec 15, 2023
@JereLeppanen
Copy link
Collaborator Author

v2: Add commit "api: timer: add periodic.max_tmo_events in timer capability".

@shijith
Copy link

shijith commented Jan 6, 2025

Reviewed-by: Shijith Thotton <sthotton@marvell.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants