Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware deprovisioning API dry-run not working #447

Open
phavekes opened this issue Nov 29, 2024 · 3 comments
Open

Middleware deprovisioning API dry-run not working #447

phavekes opened this issue Nov 29, 2024 · 3 comments
Assignees

Comments

@phavekes
Copy link
Member

The middleware api documentation indicated a GET request to the deprovisioning endpoint will start a dry-run for the deprovidioning. When calling the API with the GET method, an error is returned instead.

curl -X "GET" -u lifecycle:password -H 'Accept: application/json' "https://middleware/deprovision/urn:collab:person:surf.nl:peter12345" -s

{"errors":["Symfony\\Component\\HttpKernel\\Exception\\MethodNotAllowedHttpException: No route found for \u0022GET \/deprovision\/urn:collab:person:surf.nl:peter12345\u0022: Method Not Allowed (Allow: DELETE)"]}⏎                                                                    
@phavekes phavekes converted this from a draft issue Nov 29, 2024
@phavekes phavekes added the bug label Nov 29, 2024
@phavekes phavekes moved this from New to Backlog in PHP development Nov 29, 2024
@johanib
Copy link

johanib commented Dec 4, 2024

Make sure the documentation in middleware is up-to-date.
Also check how EB deprovisions, that spec is leading when in doubt.

@phavekes phavekes assigned pablothedude and unassigned johanib Jan 7, 2025
@phavekes
Copy link
Member Author

phavekes commented Jan 8, 2025

Tested, still present in 6.0.0-beta3

@pablothedude pablothedude moved this from Backlog to In Progress in PHP development Jan 14, 2025
@pablothedude
Copy link
Contributor

At first sight the URL seems invalid and it should for a dry run be the following:
GET http://middleware/deprovision/urn:collab:person:surf.nl:peter12345/dry-run.

Also see: https://github.com/OpenConext/Stepup-Middleware/blob/main/docs/MiddlewareAPI.md#deprovision-api---dry-run

I will test it again when I'm done with #465.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants