Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label for new attribute surf-autorisaties #283

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Apr 3, 2024

No description provided.

@thijskh thijskh requested a review from parijke April 3, 2024 15:01
@thijskh thijskh changed the base branch from main to feature/symfony6-upgrade April 15, 2024 10:41
@thijskh thijskh force-pushed the feature/add-surf-autorisaties branch from e1ef263 to a641e51 Compare April 15, 2024 10:43
@parijke parijke merged commit f01f611 into feature/symfony6-upgrade Apr 15, 2024
1 check passed
@thijskh thijskh deleted the feature/add-surf-autorisaties branch April 15, 2024 11:17
parijke added a commit that referenced this pull request Apr 24, 2024
* Upgrade SF 4 to latest and webpack

* Fix deprecations

* Fix deprecations

* Fix sptintf warning

* Move to openconext folder
Add debug bundle

* Remove redundant script

* Add debug config

* Fix CSP for dev

* Fix PHP8 compat

* Fix php8 deprecation warnings

* Fix php config

* Delete obsolete test and fix exception expectations

* Delete obsolete assertings because of type hinting

* Fix empty assertion and exceptions

* Fix empty assertion and exceptions

* Upgrade mockery, phpunit

Fixed tests on php8

* Upgrade SF6

* Remove dotenv

* Optimized for phpunit 9

* Eliminated mockery and fixed useless dataprovider loop

* Eliminated mockery and fixed useless dataprovider loop

* PHPCBF

* Add strong(er) typing

* Fixed test

* Fixed test

* Remove mockery

* Remove mockery

* Remove mockery

* Remove mockery

* Little simpler

* Move expectation to const

* Add property promotion

* Add VoidReturnTypeWhereNoReturnRector

* Re-add getAttributes function

* Use getter instead of protected value

* Remove double version constraints

* Run Rector

* Fix vulnerability warnings

* Run test-integration on main push

* Integration tests

* Remove assert because of typing

* Rename yml to yaml

* Rename yml to yaml

* Yarn install

* Remove Action suffix

* Fix login

* Fix deprecations

* Fix translations

* Fix translations

* Fix state

* Remove obsolete Guard

* Fix phpstan

* Fix phpstan

* Fix phpstan

* Fix phpstan

* phpcbf

* Remove SamlToken

* Remove SamlToken

* Type vars

* Ran rector and strict types

* Phpstan level2

* Phpstan level 3

* Phpstan level 5

* QA tools

* Fixes

- QA tools
- Remove string tests because of strong typing
- Remove obsolete docblocks

* Fix phpcbf

* Add routeing attributes

* Remove yaml routes for profile

* Remove comments

* Move twig to templates

* Merge config files

* Fix phpcbf

* Run composer update

* Add phpstan config

* Adjust readme based on devconf

* Multiline parameters

* Sort use statements automatically

* Correct copyright year

* Correct copyright year

* Make php version with more checks

* Add file counter

* Remove empty line

* Remove redundant doc comments

* Rename templateEngine to twig

* Add typing

* Make linkedId nullable

* Remove aa/api from aa connection

* Remove doctrine/annotations

* Fix all nsmaspaces

* Remove unused dev dependencies

* Amend changelog

* label for new attribute surf-autorisaties (#283)

* Remove twig

Twig is already aavailable via the AbstractController, so we can use that and skip the Environment DI

* Remove SamlListener

This routing is done by the SamlBundle, and is not needed here anymore

* Add component_info

* Add archive section to composer.json. This allows building with the stepup build script

* Created yarn.lock

* Install http client

* Change engineblock to httpClient

Change to httpClient

* Ran QA tools

- removed obsolete baselines from phpstan
- phpcbf changes method formatting

* Replace GuzzleHttp client with Symfony HttpClient in AttributeAggregationApiClientBundle

* Refactor unsubscribeAccount method to handle exceptions in AttributeAggregationRepository

json_decode returned mixed (true, false or null), but the new implementation throws exceptions. So if no exceptions are catched, it is considered to be successful

* Replace GuzzleHttp client with Symfony HttpClient in UserLifecycleApiClientBundle, adjust namespaces, and refactor JsonApiClient for Symfony HttpClient compatibility

* Refactor JsonApiClient tests and implementation to use Symfony HttpClient across various ApiClientBundles, removing Guzzle dependencies

* Remove GuzzleHttp dependency from composer.json

* Add daily security check GitHub Action and update README for yarn usage

* Update services.yaml to refine OpenConext resource loading and remove obsolete ApiClientBundle configurations

* Update services.yaml to exclude Profile Value objects from Symfony resource loading

* Remove obsolete folder

* Fix GET request by removing 'exceptions' option

* Update UserService dependency injection

* Refactor services configuration and centralize email and locale settings in global services.yaml

* Update CHANGELOG

* De-bundle engineblock API

* Remove Bundle from namespace

* Remove controller service arguments tag from services.yaml in ProfileBundle

* Align the package build process with the rest of OpenConext
The workflow to build the package has been rewritten to use Stepup-Build
for building the package

* Build workflow: Checkout stepup-build

* Build workflow: Use the correct project name

* Docker: Upgrade the image used for production images to php8.2

* Build action: Add permissions for creating a release

* Docker build workflow: Bring in line with the other OpenConext app

* Build action: Add more permissions for creating a release

* Prod dockerfile: Fix a typo

* Docker build: Download tar.bz2 not tar.gz

* GitHub actions workflows: Remove deprecated set-output commands

* Build workflow: Phase out deprecated create release action

* Build workflow: Use auto generated release notes from the new action
that is used to create releases. No more need for a seperate action

* Fix a small typo in the brand "ORCID iD"

* Tighten security headers a bit

* Also the /internal/{info,health} paths must be publically available

BSR: remove unused stanza

* Sync NL / EN menu captions

* Use app_secret instead of secret

* Add doctrine/annotations (required for JMS)

* Override getProjectDir in Kernel for compatibility

* Update monolog config to direct logs to stderr

* Change PHPMD output format from XML to text in QA script

* Update PHPStan baseline and increase analysis level to 9

* Update PHPStan baseline and increase analysis level to 9

* Remove local PHP security checker script

This will be done by daily-security-check.yml

* Enable UTF-8 support for router and streamline framework config across environments

* Refine AttributeAggregationRepository delete operation to handle non-OK statuses with correct body

* Upgrade doctrine/annotations to version 2.0.1 explicitly

* Enforce secure cookies and disable SameSite attribute in framework configuration

* Remove test configuration for SAML service provider and identity provider in surfnet_saml.yaml

* Enable caching for Webpack Encore by default and disable in development environments

* Remove obsolete configuration

* Remove Rector configuration

* Update translation overrides path for EN, NL, and PT languages

* Remove unnecessary whitespace in Kernel.php

* Remove HttpClientConfigurationTest as there's no config left

* Update baseline

* Refactor AttributeReleasePolicyServiceTest to use PHPUnit mocks and update PHPStan baseline

Remove mockery from dependencies

* Docker image build: Use the current tag to download the latest release.
Before we were using the "latest" tag to download it, which would not
work when the "pre-release" tag was set

* Add authetication context clkass reference to the required parameters

* Add testcase for repository

Because the logic is slightly changed, we want to make sure it still works, and for future refactoring

* Update translation overrides path to use absolute directory in NL, EN, and PT files

* Update README.md to streamline Development instructions.

* Fix numbering

* Refactor PHP classes to use strict types and improve doc with @throws

* phpcbf

* Simplify console

* Add exception message

* Change certificate locations

* Omit --prefer-dist

* Move to dep dependencies

* Delete string test because of strong typing

* Update baseline

---------

Co-authored-by: Michiel Kodde <mkodde@ibuildings.nl>
Co-authored-by: Thijs Kinkhorst <thijs@kinkhorst.com>
Co-authored-by: Bart Geesink <bart.geesink@surf.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants