Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize behat tests #21

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

pablothedude
Copy link
Contributor

@pablothedude pablothedude commented Nov 19, 2024

This PR has some optimizations in order to help debug failing features.

  • Make behat replay logic more verbose
  • Change the deprecated twig localizeddate function
  • Run all Behat features in isolation

Todo:

  • add dedicated replay test

@pablothedude pablothedude force-pushed the feature/make-behat-replay-more-verbose branch 2 times, most recently from a64e981 to 7aec0d4 Compare November 20, 2024 13:54
@pablothedude pablothedude force-pushed the feature/make-behat-replay-more-verbose branch from 6e7f489 to 0e43820 Compare December 4, 2024 14:59
When provisioning the tests output the commands and stop when this
fails. So you are aware if something is broken.
The initialization config for the tests are now using the same config
as middleware is using when a new environment is bootstrapped.

After the initial setup of the tests a mysqldump is created in
order to run all test in isolation and prevent unwanted side effects.

And the event stream is no only used to boostrap an SRAA with a token.
@pablothedude pablothedude force-pushed the feature/make-behat-replay-more-verbose branch from 0e43820 to 5fe6083 Compare December 4, 2024 14:59
@pablothedude pablothedude force-pushed the feature/make-behat-replay-more-verbose branch from 5fe6083 to 82bed25 Compare December 4, 2024 15:11
Copy link

@johanib johanib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

stepup/tests/behat/features/replay.feature Outdated Show resolved Hide resolved
@pablothedude pablothedude force-pushed the feature/make-behat-replay-more-verbose branch from 82bed25 to 19bfffc Compare December 5, 2024 09:32
@pablothedude pablothedude merged commit 9330b7a into main Dec 5, 2024
2 checks passed
@pablothedude pablothedude deleted the feature/make-behat-replay-more-verbose branch December 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants