Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] only kill session in sseMiddleware for auth bearer sessions (#9216) #9708

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jan 24, 2025

Proposed changes

  • killing all sessions was making it it so local user were being disconnected if they tried accessing a closed stream

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec linked an issue Jan 24, 2025 that may be closed by this pull request
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 24, 2025
Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok with opening a stopped stream ; I'm not logged out.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.18%. Comparing base (98505a2) to head (9c336c8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...tform/opencti-graphql/src/graphql/sseMiddleware.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9708      +/-   ##
==========================================
+ Coverage   65.23%   66.18%   +0.94%     
==========================================
  Files         630      630              
  Lines       60273    60408     +135     
  Branches     6762     7299     +537     
==========================================
+ Hits        39320    39981     +661     
+ Misses      20953    20427     -526     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec merged commit 7ed76c1 into master Jan 27, 2025
9 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/9216 branch January 27, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on a stopped live stream logout from the platform
2 participants