Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] use new loader in report overview (#8288) #8385

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Sep 17, 2024

Proposed changes

  • use new loader in report overview
  • use new loader in all widget
  • remove WidgetLoader

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@frapuks frapuks self-assigned this Sep 17, 2024
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Sep 17, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.05%. Comparing base (66fa73c) to head (ad18b3a).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8385      +/-   ##
==========================================
- Coverage   66.06%   66.05%   -0.01%     
==========================================
  Files         597      597              
  Lines       60913    60913              
  Branches     6206     6203       -3     
==========================================
- Hits        40241    40238       -3     
- Misses      20672    20675       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks marked this pull request as ready for review October 15, 2024 13:56
@frapuks frapuks merged commit 671a784 into master Oct 17, 2024
6 checks passed
@frapuks frapuks deleted the issue/8288 branch October 17, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'entities overview' loader is not the one used in the rest of the application
2 participants