Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Improve Simulation buttons CSS (#8231) #8232

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Sep 3, 2024

Proposed changes

  • Fix horizontal scrollbar issue
  • Improve buttons display to have better hover

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Sep 3, 2024
@lndrtrbn lndrtrbn self-assigned this Sep 3, 2024
@lndrtrbn lndrtrbn changed the title improve Simulation buttons CSS [frontend] Improve Simulation buttons CSS (#8231) Sep 3, 2024
@lndrtrbn lndrtrbn linked an issue Sep 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (26d2128) to head (ca6e1b0).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8232      +/-   ##
==========================================
+ Coverage   66.13%   66.14%   +0.01%     
==========================================
  Files         597      597              
  Lines       59927    59927              
  Branches     6150     6152       +2     
==========================================
+ Hits        39634    39641       +7     
+ Misses      20293    20286       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard merged commit d9a39c5 into master Sep 9, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the issue/8231 branch November 2, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Regression : horizontal scrollbar on details page
4 participants