Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Create Relationship" Button to Objects #7034

Open
wants to merge 20 commits into
base: release/6.5.0
Choose a base branch
from

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Added a "Create Relationship" button to most entity pages (not containers)
  • Replaced speed dial in relationship creation drawers
  • Added resolver to get valid targets for nested ref relationships
  • Nested object drawer only shows valid targets now

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Sorry, something went wrong.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.39%. Comparing base (c4d68ee) to head (c6cc210).
Report is 1 commits behind head on release/6.5.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #7034      +/-   ##
=================================================
+ Coverage          64.37%   64.39%   +0.02%     
=================================================
  Files                644      644              
  Lines              62137    62157      +20     
  Branches            6890     6898       +8     
=================================================
+ Hits               39998    40028      +30     
+ Misses             22139    22129      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano added the community use to identify PR from community label May 21, 2024
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from d30baf0 to f863b8b Compare May 21, 2024 12:30
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from f863b8b to 714a0db Compare June 6, 2024 15:36
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 3 times, most recently from ab87c9e to 2827bcb Compare June 17, 2024 18:16
@SamuelHassine SamuelHassine force-pushed the master branch 3 times, most recently from b710111 to c15ed81 Compare June 23, 2024 20:06
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from a8e30c3 to 3a5fb83 Compare August 6, 2024 14:42
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from b1c0107 to 8d1464c Compare August 13, 2024 11:20
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from 93f3707 to f9bf6d5 Compare August 21, 2024 19:03
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 2 times, most recently from 9cda64d to 7440b45 Compare September 10, 2024 12:40
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from 7315427 to d55f929 Compare September 17, 2024 12:50
@labo-flg labo-flg force-pushed the release/6.5.0 branch 5 times, most recently from 9535c45 to 8574b42 Compare January 17, 2025 16:11
@Archidoit Archidoit force-pushed the feature/fab_replacement/create/relationships branch from eab4d38 to c6cc210 Compare January 22, 2025 09:41
@Archidoit
Copy link
Member

Creation of relationships with observables from the Overview is broken:

  • Go to a Threat Actor
  • In the Overview tab, click on 'create relationship'
  • Select an observable and continue
  • an error occurs

@Archidoit
Copy link
Member

In an attack pattern, when creating a relationship with an artifact, we can't reverse the relationship anymore

now:
image

before:
image

@Archidoit
Copy link
Member

When I create a relationship of type 'delivers' between an attack pattern and a malware, the relationship is not present in the list (whereas relationship between Attack pattern and malware of type 'uses' are displayed) :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants