Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add division model k-calibration #276

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add division model k-calibration #276

wants to merge 8 commits into from

Conversation

steinnymir
Copy link
Member

Add the simpler momentum calibration method proposed by @balerion.

@steinnymir steinnymir added this to the FLASH BT Nov2023 milestone Nov 16, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6897395795

  • 6 of 73 (8.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 88.934%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 2 15 13.33%
sed/calibrator/momentum.py 4 58 6.9%
Totals Coverage Status
Change from base Build 6890295349: -1.1%
Covered Lines: 5015
Relevant Lines: 5639

💛 - Coveralls

@steinnymir steinnymir linked an issue Nov 16, 2023 that may be closed by this pull request
@steinnymir
Copy link
Member Author

Change naming to reflect the actual behaviour.

This is a distortion correction, not a k calibration method

@zain-sohail
Copy link
Member

@balerion would you like to generate the parameters for it? This PR is stuck otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Momentum Calibration for FLASH
4 participants