Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/UI improvement #921

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Animesh404
Copy link
Contributor

A WIP PR for #892

Summary

added video column in dashboard with some UI improvements overall
image

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

 python -m openadapt.app.dashboard.run

@abrichr
Copy link
Member

abrichr commented Nov 18, 2024

Thank you @Animesh404 ! Can you please upload a short video demonstrating the screenshot animation/playback functionality we discussed?

@Animesh404
Copy link
Contributor Author

Thank you @Animesh404 ! Can you please upload a short video demonstrating the screenshot animation/playback functionality we discussed?

Untitled.video.-.Made.with.Clipchamp.1.mp4

@@ -0,0 +1,120 @@
"use client"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep things consistent with the rest of the code, how about we stick with four spaces? We can refactor everything to two spaces later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in b6f5c40

IconSettings,
IconEraser,
IconBook
} from '@tabler/icons-react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the formatting here and elsewhere. Your IDE should be able to do this for you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done via prettier in bd3e923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants