Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable rpmsg size #195

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Adjustable rpmsg size #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmake/options.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,9 @@ endif (WITH_ZEPHYR)

option (WITH_LIBMETAL_FIND "Check Libmetal library can be found" ON)

if (DEFINED RPMSG_BUFFER_SIZE)
add_definitions( -DRPMSG_BUFFER_SIZE=${RPMSG_BUFFER_SIZE} )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a documentation update somewhere to tell the user that they can change the default, and that changing the default will make it incompatible with the Linux kernel implementation. I think that this change or #155 is major enough to bring up in the next openamp-rp call, or on the mailing list.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edmooring,
Agree on the principle for the Documentation. We have to discuss the way to provide a documentation accessible to contributors.
Concerning this commit itself, it is not a major change. The RPMSG_BUFFER_SIZE can already be customized (https://github.com/OpenAMP/open-amp/blob/master/lib/include/openamp/rpmsg_virtio.h#L25)
So this patch only exports the definition, to be able to define the size in the make command line instead of updating the makefiles.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arnopo
For now, putting it in README.md, near the instructions for building OpenAMP for the various platforms would be fine with me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, as some other cmake options have also to be defined (e.g WITH_VIRTIO_SLAVE, WITH_VIRTIO_MASTER ) , i would propose to have a dedicated thread for this.

endif (DEFINED RPMSG_BUFFER_SIZE)

message ("-- C_FLAGS : ${CMAKE_C_FLAGS}")
# vim: expandtab:ts=2:sw=2:smartindent