shouldn't send RPMSG_NS_DESTROY if endpoint name is empty

and support rpmsg_create_ept with name == NULL Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
OpenAMP · Mar 3, 2019 · 83f2b72 · 83f2b72
1 parent 66cf86d
commit 83f2b72
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/include/openamp/rpmsg.h b/lib/include/openamp/rpmsg.h
@@ -287,7 +287,7 @@ static inline void rpmsg_init_ept(struct rpmsg_endpoint *ept,
 				  rpmsg_ept_cb cb,
 				  rpmsg_ns_unbind_cb ns_unbind_cb)
 {
-	strncpy(ept->name, name, sizeof(ept->name));
+	strncpy(ept->name, name ? name : "", sizeof(ept->name));
 	ept->addr = src;
 	ept->dest_addr = dest;
 	ept->cb = cb;

diff --git a/lib/rpmsg/rpmsg.c b/lib/rpmsg/rpmsg.c
@@ -257,7 +257,7 @@ void rpmsg_destroy_ept(struct rpmsg_endpoint *ept)
 		return;
 
 	rdev = ept->rdev;
-	if (rdev->support_ns && ept->addr != RPMSG_NS_EPT_ADDR)
+	if (ept->name[0] && rdev->support_ns && ept->addr != RPMSG_NS_EPT_ADDR)
 		(void)rpmsg_send_ns_message(ept, RPMSG_NS_DESTROY);
 	metal_mutex_acquire(&rdev->lock);
 	rpmsg_unregister_endpoint(ept);