Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T8 #1278

Merged
merged 13 commits into from
Mar 12, 2025
Merged

T8 #1278

merged 13 commits into from
Mar 12, 2025

Conversation

nmaguiar
Copy link
Collaborator

This pull request includes several changes across multiple files to improve functionality and code quality. The most important changes include updates to the job completion scripts, enhancements to the ojob and openaf JavaScript files, and a significant refactor of the CSS file for better maintainability.

Job Completion Scripts:

  • Updated the job completion command to use Java for execution instead of a shell script. (build.yaml)
  • Modified the complete/completion.yaml file to change key names and add new parameters. (complete/completion.yaml) [1] [2]
  • Added new flags and options for the complete/completion_oaf.sh and complete/completion_opack.sh scripts to handle various commands and arguments. (complete/completion_oaf.sh, complete/completion_opack.sh) [1] [2]

JavaScript Enhancements:

  • Added a check for the _r variable before merging parameters in the ojob_askOnHelp function. (js/ojob.js)
  • Introduced the logFlush function to wait for the current log promise to finish. (js/openaf.js)
  • Enhanced the getOPackRemoteDB function to include the OAF_OPACKS environment variable and handle both HTTP and local directory sources. (js/openaf.js)
  • Improved the addTodos function to set a default name for todos if not provided. (js/owrap.oJob.js) [1] [2]
  • Added a prompt to proceed with execution if there are no arguments to fill out in the askOnHelp function. (js/owrap.oJob.js)

CSS Refactor:

  • Refactored the nJSMap.css file by combining all CSS rules into a single line for better maintainability. (css/nJSMap.css)

Minor Fixes:

  • Corrected a typo in the printTree function to ensure proper ANSI escape codes. (js/openaf.js)
  • Fixed a syntax error in the ojob.yaml file related to function path and key handling. (ojob.yaml)

nmaguiar added 13 commits March 7, 2025 22:19
… preinstall, postinstall, preerase, and posterase scripts
…, postinstall, preerase, and posterase scripts
…ved parameter handling and completion output formatting
…ecution and update completion output formatting in bash and zsh scripts
@nmaguiar nmaguiar self-assigned this Mar 12, 2025
@nmaguiar nmaguiar merged commit 533d7c5 into master Mar 12, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant