-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Improvements in Route Schedule #169
base: main
Are you sure you want to change the base?
UI Improvements in Route Schedule #169
Conversation
…gle toggle button for improved usability
…padding in schedules table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't repro #163, so I'm not sure which change you've made that was supposed to fix that. In general, you should strive to submit a fix for a single issue in a single PR. If that doesn't make sense because you're accumulating several tiny fixes, then each commit should fix a single issue.
Sticky header
I see a gap above the sticky header, which is a regression.
underlined minutes
The new display for minutes is confusing to me because good links on the web are always underlined and these are not links. I am open to the possibility of a new visual treatment, but this isn't going to be it.
Show all routes button appears to be broken at first
When I first land on the schedule page, all of the routes are expanded, which means that Show All Routes does nothing.
abe711f
to
038dc1a
Compare
All the required changes were fixed as per the feedback. Thanks :) |
Fixes #164, #163
Screenshots:
Before
After