-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 15 - saved frequent user locations #20
Issue 15 - saved frequent user locations #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! as noted, I saw a couple minor issues but I will log them in a set of followup issues when I have full repro steps.
@@ -45,7 +44,7 @@ struct TripPlannerView: View { | |||
fromPlace: "47.6097,-122.3331", | |||
toPlace: "47.6154,-122.3208", | |||
time: "8:00 AM", | |||
date: "05-10-2024", | |||
date: "07-05-2024", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be composed dynamically so we don't end up in the same situation again :)
func getFormattedTomorrowDate() -> String {
let dateFormatter = DateFormatter()
dateFormatter.dateFormat = "MM-dd-yyyy"
let tomorrow = Calendar.current.date(byAdding: .day, value: 1, to: Date())!
return dateFormatter.string(from: tomorrow)
}
Adding favorite locations and recent locations functionality
Related Issues
#15
Description
This PR related to issue #15. Within this PR, the changes included are:
Media
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-07-04.at.12.49.55.mov
Test Instructions
To test this PR, you can do the following:
Additional Context
Currently, this PR not having any edit functionality for favorite location yet because for MVP, I was thinking the scope of favorite locations is just marking the searched locations only