Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Addition of Icons in Footer Section #25

Closed
wants to merge 1 commit into from
Closed

feat: Addition of Icons in Footer Section #25

wants to merge 1 commit into from

Conversation

ankitkumar748846
Copy link
Contributor

fix: #24

footer

aaronbrethorst
aaronbrethorst requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however the new links need to have a <span class='sr-only'>{description goes here}</span> added to them like the GitHub link

@ankitkumar748846
Copy link
Contributor Author

Okay Sir @aaronbrethorst

@ankitkumar748846 ankitkumar748846 mentioned this pull request Mar 4, 2024
Merged
@aaronbrethorst
Copy link
Member

this has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addition of "Icon" in footer Section
2 participants
@ankitkumar748846 @aaronbrethorst