Fixed the Double vertical scrollbar issue of sidebar and highlighting of the activenav links #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbrethorst
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Thanks @Ajay9330. I have a couple fit and finish items that I'd like to see tweaked, but I'll take care of them in a followup commit. much appreciated!
|
thank you @aaronbrethorst sir, i'll try to take care of designs principles also in future commits as you said in #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #10 and added conditional Highlighting of the active nav elements
issue #10 i had already solved the issue before raising it #9 but there was issue with local git email configuration,this was my first failed open source pull request, but again i making pull request after fixing that email issue hope it will work
#10 (comment)