-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add jsr support to doc #42
Conversation
WalkthroughThe recent update brings new features and fixes to the platform, including support for the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Actionable comments outside the diff hunks (3)
README.md (3)
Line range hint
5-5
: Consider changing "Extends this configuration using byextends
field." to "Extend this configuration by using theextends
field."- Extends this configuration using by `extends` field. + Extend this configuration by using the `extends` field.
Line range hint
31-31
: Replace "limitions" with "limitations" to correct the spelling mistake.- Currently, there are following limitions on Deno project: + Currently, there are the following limitations on Deno project:
Line range hint
31-31
: Consider adding "the" before "following limitations" for grammatical correctness.- Currently, there are following limitations on Deno project: + Currently, there are the following limitations on Deno project:
@@ -39,9 +39,11 @@ Currently, there are following limitions on Deno project: | |||
- https://raw.githubusercontent.com | |||
- https://unpkg.com | |||
- https://cdn.skypack.dev | |||
- `jsr:` specifier | |||
- See [test case](./test/deno/) for supported syntax | |||
- Dynamic import is not followed | |||
- Cannot detect tag when "/" is included in it (github-tag source(pax.deno.dev and raw.githubusercontent.com)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the documentation about tag detection. Consider rephrasing to "Cannot detect tags that include the '/' character in their names, specifically for sources like github-tag (pax.deno.dev and raw.githubusercontent.com)."
- Cannot detect tag when "/" is included in it (github-tag source(pax.deno.dev and raw.githubusercontent.com))
+ Cannot detect tags that include the '/' character in their names, specifically for sources like github-tag (pax.deno.dev and raw.githubusercontent.com).
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- Cannot detect tag when "/" is included in it (github-tag source(pax.deno.dev and raw.githubusercontent.com)) | |
Cannot detect tags that include the '/' character in their names, specifically for sources like github-tag (pax.deno.dev and raw.githubusercontent.com). |
SSIA
Summary by CodeRabbit
jsr:
specifier.deno.lock
.