Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to Prerelease doesn't work on OctoPi 1.0.0cam #13

Closed
b-morgan opened this issue Mar 28, 2024 · 6 comments
Closed

Switching to Prerelease doesn't work on OctoPi 1.0.0cam #13

b-morgan opened this issue Mar 28, 2024 · 6 comments

Comments

@b-morgan
Copy link

On my OctoPi 0.18.0, OctoPrint 1.10.0rc3 system I checked Prerelease for OctoPrint-FileCheck plugin and it updated.

On my OctoPrint 1.10.0rc3 Python 3.9.2 OctoPi* 1.0.0cam (build 2023.07.20.144556) system, I check Prerelease and it just switches back to Stable.

@foosel
Copy link
Member

foosel commented Apr 2, 2024

Can you also share a system info bundle?

@b-morgan
Copy link
Author

b-morgan commented Apr 2, 2024

It may be too late... I just brought up a browser on the system with the issue and I got an announcement that there is an update for the File Check plugin. Here is the bundle before responding to the "Update Available" and I'll hold off on updating until I hear from you.

octoprint-systeminfo-20240402054320.zip

I just checked and now the File Check Plugin says Prerelease. I guess it just took its sweet time to get there. There may have been a reboot of the system between the time I filed the original report (in the wrong place) and now.

@foosel
Copy link
Member

foosel commented Apr 2, 2024

Ah, I seem to have misunderstood the issue.

Do I understand it correctly now that the UI switches itself back to Stable? As in, selecting the Prerelease release channel on the plugin just switches it right back to Stable? If so I think I'm seeing a reproduction here, though right now I can't make sense of it, and it also affects other plugins and even OctoPrint itself, so I'll have to dig into that in general.

In any case, I think you can go ahead with updating on your end.

@b-morgan
Copy link
Author

b-morgan commented Apr 2, 2024

Yes, the UI was switching itself back to "Stable".

@foosel
Copy link
Member

foosel commented Apr 2, 2024

I fear this is actually a bug with the settings optimizations in 1.10.0. I haven't yet fully understood why it works in some cases and in others doesn't, but it very much looks like a regression... Looks like I'll need to push out a 1.10.0rc4 after all :/

@foosel
Copy link
Member

foosel commented Apr 3, 2024

Yes, this is indeed due to an OctoPrint bug and now tracked in OctoPrint/OctoPrint#4983

For the record, it was a very specific corner case triggering a bug in the internal settings cache. My guess is the instance on which things worked for you had had the setting set at some point already, the other broken one didn't.

@foosel foosel closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in OctoPrint Backlog Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants