Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.14.0) Overhauls sediment #236

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f18ea41
first crack at fixing up sediments
jagoosw Dec 31, 2024
30db3ce
added instant reminerlaisation and tests
jagoosw Jan 2, 2025
90b5af5
reinstated simple multi g + tests
jagoosw Jan 3, 2025
8d589dd
fixed (?)
jagoosw Jan 6, 2025
e1a3ff7
make spelling consistent
jagoosw Jan 7, 2025
e240338
added some docstrings
jagoosw Jan 7, 2025
c38d4a7
fixed bottom indies
jagoosw Jan 13, 2025
6e975e5
fixed includes
jagoosw Jan 13, 2025
0e68e77
attempt to fix bottom index again
jagoosw Jan 14, 2025
3912778
attempt to fix bottom index again
jagoosw Jan 14, 2025
df1aead
GPU fix(?)
jagoosw Jan 14, 2025
3d0af3e
throw away symbols in adapt
jagoosw Jan 14, 2025
75f5b43
import adapt_structure
jagoosw Jan 14, 2025
54c7035
names
jagoosw Jan 18, 2025
ed9d832
Merge remote-tracking branch 'origin' into jsw/refactor-sediment
jagoosw Jan 27, 2025
5d05f86
added show/summary methods for sediment + fixed docstrings
jagoosw Jan 27, 2025
df4951d
fix docs
jagoosw Jan 27, 2025
5f3eb70
maybe fix scalar indexing
jagoosw Jan 27, 2025
6392233
attempt to fix test again
jagoosw Jan 29, 2025
14d50c3
fix docs again
jagoosw Jan 29, 2025
4c0fd77
guess sediments don't work with box model grids
jagoosw Jan 30, 2025
ad9d90b
attempt to fix test again
jagoosw Jan 30, 2025
a3ff38e
fixed make
jagoosw Feb 5, 2025
903df19
fixed make
jagoosw Feb 5, 2025
be307ea
hopefully fixed docs
jagoosw Feb 5, 2025
41a2b84
oops
jagoosw Feb 10, 2025
fb2c268
maybe it would be faster to run locally
jagoosw Feb 10, 2025
7f53a6a
hopeflly fixed the strange error which I also now get locally
jagoosw Feb 11, 2025
c0fec31
bump version
jagoosw Feb 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
attempt to fix test again
  • Loading branch information
jagoosw committed Jan 29, 2025
commit 6392233756f7d4a5226ca6cebc080109974317eb
2 changes: 1 addition & 1 deletion test/test_sediments.jl
Original file line number Diff line number Diff line change
@@ -75,7 +75,7 @@ function test_sediment(grid, biogeochemistry, model_name, advection = WENO(order
# simple multi-G is only good to this precision, IR is fine to default
@test isapprox(initial_total_nitrogen, final_total_nitrogen,rtol = 0.2e-6)

@test all(Array(interior(sediment_nitrogen)) .!= 0)
@test all(interior(Field(sediment_nitrogen)) .!= 0)

return model
end