(0.9.0) Fix typos in code, docs, and docstrings

[pitmonticone]

This PR is a breaking change as it corrects spellings in the API. Changes in parameter names occur in:

• LOBSTER
• SLatissima
• InstantRemineralisation

[navidcy]

Lgtm!

@jagoosw are these breaking changes?

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8d3a355) 64.19% compared to head (74cdc73) 64.19%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   64.19%   64.19%           
=======================================
  Files          27       27           
  Lines        1064     1064           
=======================================
  Hits          683      683           
  Misses        381      381           

Files	Coverage Δ
...c/Boundaries/Sediments/instant_remineralization.jl	79.16% <ø> (ø)
src/Boundaries/Sediments/simple_multi_G.jl	94.11% <ø> (ø)
src/Models/AdvectedPopulations/LOBSTER/LOBSTER.jl	70.00% <100.00%> (ø)
...AdvectedPopulations/LOBSTER/carbonate_chemistry.jl	100.00% <100.00%> (ø)
src/Models/AdvectedPopulations/LOBSTER/core.jl	100.00% <100.00%> (ø)
...rc/Models/AdvectedPopulations/LOBSTER/fallbacks.jl	100.00% <ø> (ø)
...ls/AdvectedPopulations/LOBSTER/oxygen_chemistry.jl	100.00% <100.00%> (ø)
src/Models/AdvectedPopulations/NPZD.jl	87.50% <ø> (ø)
src/Models/Individuals/SLatissima.jl	84.86% <100.00%> (ø)
src/OceanBioME.jl	68.75% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[navidcy]

@pitmonticone I added few suggestions for code alignment.

[pitmonticone]

@pitmonticone I added few suggestions for code alignment.

@navidcy Committed.

[jagoosw]

Thank you @pitmonticone !

This is indeed a breaking change.

@navidcy if there are no changes needed could we add the latest Oceananigans compats in this PR before we push a minor release too?

[navidcy]

Sure, I can do that.

But I suggest we drop the support to previous Oceananigans since v0.90 introduced a big change to the API and I don't see how we could possibly support both pre-v0.90 and post/= v0.90.

[jagoosw]

@navidcy updating to 0.90 might be quite a lot of work, I can sort it tomorrow if you want. I agree I don't think it's likely we could support both and I think we'd probably want to make some changes for consistency with it.

Perhaps that should be a different PR that we merge first.

[navidcy]

@jagoosw I just saw your post.

I already pushed changes in the Manifest+Project for Oceananigans v0.90. I looked through the examples and, to me, it didn't seem that we need to change anything. If the tests fail I'll revert my changes and we can open another one for Oceananigans v0.90.

how does this sound?

[navidcy]

@jagoosw, ok .. things fail.
let's update Oceananigans to v0.90.1 in a different PR and then merge this one

[jagoosw]

@jagoosw, ok .. things fail. let's update Oceananigans to v0.90.1 in a different PR and then merge this one

I'll make a new PR, I suspect I may need todo some work for the light attenuation and gas exchange stuff as they use nodes.

[navidcy]

OK @pitmonticone, we'll wait for #157 first before merging this one. Once #157 is merged then we'll merge this one ;)

[navidcy]

@jagoosw, when tests pass I'll merge