-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gas transfer coefficients #168
Comments
Hi @vtamsitt, thanks! That would be great and what you suggest seems like a good approach |
Great, I'll work on this when I get a chance. |
It could make sense to add a property called OceanBioME.jl/src/Boundaries/gasexchange.jl Line 142 in 0b45a16 then it'll be easy to add new models (for developers) or to switch between models (for users) |
Closed by #186 |
I'm interested in implementing updated gas transfer velocity (k) parameterisations (at the very least, Wanninkhof 1992 is outdated and could be replaced by Wanninkhof 2014). It would be great to add other gas transfer velocities e.g. Ho et al. 2006, as is mentioned in the code comments. I'm guessing the best way to implement this would be to add all of these parameterisations (and more?) and include a kwarg when calling GasExchange?
OceanBioME.jl/src/Boundaries/gasexchange.jl
Line 127 in 0b45a16
The text was updated successfully, but these errors were encountered: