added service logging for detected ports #1024
Open
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related to (doesn't completely solve) issue #1023. This PR aims to give the detected services as outputs to the user. Earlier, the output of a port scan looked like this:
With these tweaks, the output now looks like this, (I've run a dir_scan here to show how the logs vary)
This is different from regex matching. It relies on the
getservbyport()
function called inside socket.py.Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally