Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added service logging for detected ports #1024

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pUrGe12
Copy link
Contributor

@pUrGe12 pUrGe12 commented Feb 22, 2025

Proposed change

Related to (doesn't completely solve) issue #1023. This PR aims to give the detected services as outputs to the user. Earlier, the output of a port scan looked like this:

image

With these tweaks, the output now looks like this, (I've run a dir_scan here to show how the logs vary)

image

This is different from regex matching. It relies on the getservbyport() function called inside socket.py.

Type of change

  • New core framework functionality
  • Bugfix (non-breaking change which fixes an issue)
  • Code refactoring without any functionality changes
  • New or existing module/payload change
  • Localization improvement
  • Dependency upgrade
  • Documentation improvement

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@securestep9
Copy link
Collaborator

@pUrGe12 please see my comments in Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants