Correction of a few bugs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update osemosys.py
|
Hi @ThomasHeggarty - many thanks for these contributions. Could you clarify what the issues are that your pull request addresses? Best practice is to create an issue (as you have done) with are detailed explanation of the problem and the effects of it. You can then link to it from your pull request by using the hash symbol e.g. #1 |
Closed
|
Perfect, super clear. Thanks so much! We’ll review and merge this in as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first couple of corrections were made for the code to match the problem description in the OSeMOSYS documentation. The last four corrections are pyomo syntax related issues.