Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up ci workflow secret handling #20

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

Nyumat
Copy link
Member

@Nyumat Nyumat commented Nov 2, 2024

This pull request includes changes to the CI workflow configuration in the .github/workflows/ci.yml file. The most important changes involve the removal of environment variables and steps related to creating a .env.local file.

Changes to CI workflow configuration:

Note

This PR is mostly experimental to figure out what is the best way to expose our environment variables within GitHub actions while also reinforcing security and ease-of-use.

@Nyumat
Copy link
Member Author

Nyumat commented Nov 2, 2024

These new changes worked, so we're cool now. We'll now just need to enforce non-fork pull requests so that we can safely utilize our repository GA-specific secrets.

@Nyumat Nyumat merged commit d5d6875 into main Nov 2, 2024
1 check passed
@Nyumat Nyumat deleted the nyumat/ci-back-on-track branch November 4, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant