fix: raster import and TimeSeriesMap rendering issues #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
temporal
sudhanshu112233shukla
changed the title
|
I tested it, but it doesn't help. I think this will need larger changes. |
|
@petrasovaa can you guide me , or give me some overview I will try my best to solve this. |
|
TimeSeriesMap and SeriesMap were written separately and then later we created a BaseSeriesMap because they have a lot in common. But that was not done entirely correctly, some of the TSM structures are different then the SM, which is somehow causing the bug. So I would look at the rendering commands when they are called. |
…3shukla/grass into codefixes" This reverts commit 7e42dbd, reversing changes made to 420720a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved raster import failure and corrected TimeSeriesMap rendering by handling dataset accessibility and granularity errors. Closes #5304 .