Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i.sam2: use lazy import for torch #1338

Merged
merged 2 commits into from
Feb 21, 2025
Merged

i.sam2: use lazy import for torch #1338

merged 2 commits into from
Feb 21, 2025
+15 −11

Conversation

neteler
Copy link
Member

@neteler neteler commented Feb 21, 2025

i.sam2: use lazy import for torch to avoid Python error:

Traceback (most recent call last):
  File "/home/neteler/.grass8/addons/i.sam2/scripts/i.sam2", line 69, in <module>
    import torch
ModuleNotFoundError: No module named 'torch'

Also

  • fix HTML error (img)
  • add HTML alt tag
  • fix typos in several manual pages

@neteler
i.sam2: use lazy import for torch
255478e 
- i.sam2: use lazy import for torch
- fix various typos in manual
@neteler neteler added the bug Something isn't working label Feb 21, 2025
@neteler neteler requested a review from cwhite911 February 21, 2025 07:44
@neteler neteler self-assigned this Feb 21, 2025
cwhite911
cwhite911 suggested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@cwhite911 cwhite911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change otherwise everything looks good.

@cwhite911 cwhite911 self-requested a review February 21, 2025 15:14
@cwhite911
Copy link
Contributor

@petrasovaa I accidentally requested your review.

@neteler neteler merged commit e9df778 into OSGeo:grass8 Feb 21, 2025
7 checks passed
@neteler neteler deleted the i_sam2_lazy_import branch February 21, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhite911 cwhite911 cwhite911 approved these changes

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees

@neteler neteler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neteler @cwhite911 @petrasovaa