Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add timeout to .gunittest.cfg file #1318

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Feb 16, 2025

Also to address a part of #1312.

Adding a default timeout value to .gunittest.cfg in grass-addons too, like for the main repo.

5 minutes is probably not enough because some tests are really long, but I want to see which ones are timing out on the CI runners speed first.

Even though #1314 limited the test step to 45 minutes, the r.futures.calib apparent hang already happens after 7 minutes, so there's almost 40 minutes spent waiting on timing out.

@wenzeslaus
Copy link
Member

Thanks!

@echoix
Copy link
Member Author

echoix commented Feb 16, 2025

At least for now its getting further..

@echoix
Copy link
Member Author

echoix commented Feb 16, 2025

I compared the two test reports, with an older one, and two of previously passing tests that were timing out here were just close to the limit.

For example, ./temporal/t.rast.import.netcdf – test_t_rast_import_netcdf already passed in 4:49, and ./raster/r.viewshed.exposure – test_r_viewshed_exposure passed in 5:05.
In that same 3.11 passing test report, when ./raster/r.futures/r.futures.calib – test_r_futures_calib passes, it takes 0:17.45 (17.45 seconds)

@echoix echoix merged commit 6cb3328 into OSGeo:grass8 Feb 16, 2025
6 of 7 checks passed
@echoix echoix deleted the gunittest-timeout branch February 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants