r.viewshed.exposure: Change nproc to 4 to speed up CI tests #1311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I measured about a 30sec time reduction by not using 10 cores, while the runners have 4 cores available. However, the r.univar stats didn't match exactly for the sum of test_lakes, at least not with a precision of 1E-5. So I measured multiple points, with different nproc values, to see what would be a good choice.
I chose midpoint of 1 and 10 core (on x64), they were the min and max before the 20 core that was further off. With a 4E-5 precision, all of the nproc values would be included.
Here is a bit of the commented code before I removed it through the last commit. Let me know if it should be kept, or having the info in the PR is enough.