Validate EdDSA mechanism parameter length #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Nov 29, 2024
|
I updated the PR with suggested changes |
etienne-lms
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Thanks a lot @mzachar for reporting and fixing this issue.
Could you add prefix libckteec: to the commit message header line? With that addressed,
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>.
|
@jforissier, could you launch CI tests for this P-R? |
|
@mzachar, could you add the review tag i posted into you commit message so that @jforissier can merge your change? |
This fixes Segmentation fault when no parameter is provided as specified in pkcs11 v3.0 spec for Ed25519 Signature Scheme Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com> Signed-off-by: Matej Zachar <zachar.matej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run into an segmentation fault when using following command:
$ pkcs11-tool --module /usr/lib/libckteec.so.0 --login --sign -m EDDSA --slot 0 --id 01 --input-file /tmp/data --output-file /tmp/data.sigAfter bit of digging I found out that there is no parameterLen validation in EdDSA mechanism branch which result in null pointer dereference.
This fixes Segmentation fault when no parameter is provided as specified in pkcs11 v3.0 spec for Ed25519 Signature Scheme