fix: truncate username when too long #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4114
|
| Run status |
|
| Run duration | 05m 42s |
| Commit |
|
| Committer | Jose Paiva |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
79
|
| View all changes introduced in this branch ↗︎ | |
joseh29
force-pushed
the
4101-fix-truncate-username
branch
from
d307ed9 to
5473dd8
Compare
This commit truncates the Username when is longer than the limit of the page. It also adds a tooltip for users to see the username when it's truncated. 4101
joseh29
force-pushed
the
4101-fix-truncate-username
branch
from
5473dd8 to
74e96f8
Compare
mariojsnunes
approved these changes
Jan 29, 2025
|
🎉 This PR is included in version 2.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Nice one, thanks for this @joseh29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#4101
What is the new behavior?
This PR truncates the Username when is longer than the limit of the page.
It also adds a Tooltip for users to see the username when it's truncated.
Does this PR introduce a DB Schema Change or Migration?
Git Issues
Closes #4101
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.