Run UPDATE STATISTICS on codeset table. (#197)

Fixes #192.
OHDSI · Aug 25, 2023 · f37f535 · f37f535
1 parent fa4391b
commit f37f535
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/org/ohdsi/circe/cohortdefinition/CohortExpressionQueryBuilder.java b/src/main/java/org/ohdsi/circe/cohortdefinition/CohortExpressionQueryBuilder.java
@@ -171,9 +171,9 @@ public String getCodesetQuery(ConceptSet[] conceptSets) {
     String queryWithInsert = StringUtils.replace(
             CODESET_QUERY_TEMPLATE,
             "@codesetInserts",
-            "INSERT INTO #Codesets (codeset_id, concept_id)\n" + unionSelectsQuery
+            "INSERT INTO #Codesets (codeset_id, concept_id)\n" + unionSelectsQuery + ";"
     );
-    return queryWithInsert + ";";
+    return queryWithInsert;
 
   }
 

diff --git a/src/main/resources/resources/cohortdefinition/sql/codesetQuery.sql b/src/main/resources/resources/cohortdefinition/sql/codesetQuery.sql
@@ -5,3 +5,5 @@ CREATE TABLE #Codesets (
 ;
 
 @codesetInserts
+
+UPDATE STATISTICS #Codesets;
diff --git a/src/test/java/org/ohdsi/circe/cohortdefinition/CohortExpressionQueryBuilderTest.java b/src/test/java/org/ohdsi/circe/cohortdefinition/CohortExpressionQueryBuilderTest.java
@@ -42,7 +42,7 @@ public void getCodesetQueryEmptyConceptSets() {
         assertThat(codesetQuery, equalTo("CREATE TABLE #Codesets (\n" +
                 "  codeset_id int NOT NULL,\n" +
                 "  concept_id bigint NOT NULL\n" +
-                ")\n;\n\n\n"));
+                ")\n;\n\n\n\nUPDATE STATISTICS #Codesets;\n"));
     }
 
     @Test
@@ -53,7 +53,7 @@ public void getCodesetQueryNullConceptSets() {
         assertThat(codesetQuery, equalTo("CREATE TABLE #Codesets (\n" +
                 "  codeset_id int NOT NULL,\n" +
                 "  concept_id bigint NOT NULL\n" +
-                ")\n;\n\n\n"));
+                ")\n;\n\n\n\nUPDATE STATISTICS #Codesets;\n"));
     }
 
     private ConceptSet createConceptSet(int id, String name) {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,3 +5,5 @@ CREATE TABLE #Codesets (
		;

		@codesetInserts

		UPDATE STATISTICS #Codesets;