feat: Add Grafana overlays configurations for OBS #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computate
requested changes
Feb 19, 2024
grafana/overlays/nerc-ocp-obs/grafanadatasources/observability-metrics.yaml
Outdated
Show resolved
Hide resolved
computate
approved these changes
Feb 20, 2024
|
I will squash & merge the three commits afterwards. We just tried the github way with Jeet to apply changes over a review comment. |
larsks
requested changes
Feb 20, 2024
grafana/overlays/nerc-ocp-obs/externalsecrets/oauth-client-secret.yaml
Outdated
Show resolved
Hide resolved
|
thanks larsks for our call yesterday. will work on the secrets topic. |
jbasu01
approved these changes
Feb 21, 2024
schwesig
force-pushed
the
20240210_grafanaOnObs
branch
from
82ae679 to
1cb1a6b
Compare
larsks
requested changes
Mar 4, 2024
grafana/overlays/nerc-ocp-obs/externalsecrets/oauth-client-secret.yaml
Outdated
Show resolved
Hide resolved
schwesig
force-pushed
the
20240210_grafanaOnObs
branch
4 times, most recently
from
845a451 to
4133e1b
Compare
computate
requested changes
Mar 5, 2024
Following the working POC in the INFRA cluster to set up grafana on OBS. Setting the obs grafana external secrets in vault Signed-off-by: /Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com> Co-authored-by: Jeet Basu <90354297+jbasu01@users.noreply.github.com> fix: Update URLs & privileges, simplify keypulling Resolving comments and suggestions from @larsks: - Update Grafana URLs to canonical url obs.nerc.mghpcc.org - Simplify key pulling by using dataFrom and stick to the vault names - Authenticate against OBS instead INFRA - Change Admin privileges to nerc-ops fix: Update URL to obs
schwesig
force-pushed
the
20240210_grafanaOnObs
branch
from
4133e1b to
91cad8b
Compare
computate
approved these changes
Mar 6, 2024
larsks
approved these changes
Mar 6, 2024
schwesig
added a commit
to schwesig/OCP-on-NERC_nerc-ocp-config
that referenced
this pull request
Mar 8, 2024
Following the working POC in the INFRA cluster to set up grafana on OBS. Setting the obs grafana external secrets in vault Signed-off-by: /Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com> Co-authored-by: Jeet Basu <90354297+jbasu01@users.noreply.github.com> fix: Update URLs & privileges, simplify keypulling Resolving comments and suggestions from @larsks: - Update Grafana URLs to canonical url obs.nerc.mghpcc.org - Simplify key pulling by using dataFrom and stick to the vault names - Authenticate against OBS instead INFRA - Change Admin privileges to nerc-ops fix: Update URL to obs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the working POC in the INFRA cluster to set up grafana on OBS.
@jbasu01 @harshil-codes @schwesig @computate