Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] website_snippet_country_dropdown: Migration to version 18.0 #1090

Merged

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa commented Feb 20, 2025

cc @Tecnativa TT54401

@chienandalu @CarlosRoca13 please review

sergio-teruel and others added 19 commits February 20, 2025 18:54
* Add demo page.
* CSS to Sass. Include compiled version and CSS map.
* Fix typo.
* Refactor snippet code.

  - The `js_country_dropdown` class is added automatically by the template.
  - Add `extra_class` variable to highest div element. You can set it to `has-error` for example.
  - Add `default_value` variable to autopopulate the inputs.
  - `default_country` is smarter now.
* Translate to Spanish.
* Choose user's country by default.

  With this patch, when the currently logged-in user has a country in its profile, it will be chosen by default for the flag.
* Some minor improvements: fix a string, add placeholder support, document variables.
* Acknowledge problem about drag and drop
* Remove example link.
Allow to set custom classes to input tag with id 'no_country_field'
- Remove some garbage code.
- Add readonly mode.
- Add demo data.
- Improve tour.

@Tecnativa TT17694
Currently translated at 100.0% (9 of 9 strings)

Translation: website-12.0/website-12.0-website_snippet_country_dropdown
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_country_dropdown/es/
Currently translated at 100.0% (9 of 9 strings)

Translation: website-15.0/website-15.0-website_snippet_country_dropdown
Translate-URL: https://translation.odoo-community.org/projects/website-15-0/website-15-0-website_snippet_country_dropdown/it/
@pedrobaeza
Copy link
Member

/ocabot migration website_snippet_country_dropdown

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 20, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 20, 2025
6 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_snippet_country_dropdown branch 4 times, most recently from 382817d to d727fb7 Compare February 21, 2025 10:35
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review February 21, 2025 10:35
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_snippet_country_dropdown branch 2 times, most recently from 22f37e4 to 4fe9a2c Compare February 21, 2025 11:22
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_snippet_country_dropdown branch from 4fe9a2c to d329e9e Compare February 24, 2025 08:27
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1090-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 59aa865 into OCA:18.0 Feb 25, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cf39d0e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-website_snippet_country_dropdown branch February 25, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.