Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] website_google_tag_manager: Migration to 18.0 #1081

Open
wants to merge 57 commits into
base: 18.0
Choose a base branch
from
Open

[MIG] website_google_tag_manager: Migration to 18.0 #1081

wants to merge 57 commits into from

Conversation

SodexisTeam
Copy link
Member

No description provided.

@SodexisTeam SodexisTeam force-pushed the 18.0-mig-website_google_tag_manager branch from acbeb4f to 842d5fe Compare December 31, 2024 10:23
@StefanRijnhart
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@StefanRijnhart The rebase process failed, because command git push --force sodexis tmp-pr-1081:18.0-mig-website_google_tag_manager failed with output:

remote: Permission to sodexis/website.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/sodexis/website/': The requested URL returned error: 403

@StefanRijnhart
Copy link
Member

@SodexisTeam can you rebase to fix tests?

@amkarthik
Copy link
Member

@StefanRijnhart
Done.

@StefanRijnhart
Copy link
Member

@amkarthik Did something not go as planned? I'm surprised to see that commits (and actual changes) that were merged to the 18.0 branch recently are now showing up here in this branch, as if the 18.0 branch was rebased onto this PR's branch rather than the other way around.
image

sebalix and others added 24 commits February 4, 2025 11:50
@sebalix @amkarthik
[ADD] New module 'website_google_tag_manager' (OCA#278)
5b81f3a 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
@oca-transbot @amkarthik
OCA Transbot updated translations from Transifex
c37f5c1
@cristinamartinrod @amkarthik
[11.0][MIG] website_google_tag_manager: Migration to 11.0
7ceb60c
@OCA-git-bot @amkarthik
[UPD] README.rst
4681408
@oca-travis @amkarthik
[UPD] Update website_google_tag_manager.pot
3e93c59
@cristinamartinrod @amkarthik
[12.0][MIG] website_google_tag_manager: Migration to v12
9123b70
@OCA-git-bot @amkarthik
[UPD] README.rst
bd51c24
@oca-travis @amkarthik
[UPD] Update website_google_tag_manager.pot
3f3e4ed
@oca-transbot @amkarthik
Update translation files
8aff23a 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@smurf-U @amkarthik
[MIG] website_js_below_the_fold: Migration to 12.0
f5ab302
@cristinamartinrod @amkarthik
[12.0][FIX] website_google_tag_manager: Fix travis error
df1f308
@OCA-git-bot @amkarthik
[UPD] README.rst
87e0357
@oca-travis @amkarthik
[UPD] Update website_google_tag_manager.pot
e3ab496
@oca-transbot @amkarthik
Update translation files
7667f7b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/
@OCA-git-bot @amkarthik
[UPD] README.rst
fec4fbb
@smurf-U @amkarthik
website_google_tag_manager: fix RST
0e38133
@OCA-git-bot @amkarthik
[UPD] README.rst
8adf470
@amkarthik
Translated using Weblate (French)
810b870 
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/fr/
@OCA-git-bot @amkarthik
[UPD] README.rst
054afb0
@smurf-U @amkarthik
[MIG] website_img_dimension: Migration to 12.0
a300e84
@smurf-U @amkarthik
[IMP] website_google_tag_manager README.rst file
cfdcdaf
@amkarthik
Translated using Weblate (Portuguese (Brazil))
808ea98 
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/pt_BR/
@OCA-git-bot @amkarthik
[UPD] README.rst
754a6e6
@bjornbillen @amkarthik
[MIG] website_google_tag_manager: Migration to 13.0
4b864f9
OCA-git-bot and others added 19 commits February 4, 2025 11:50
@OCA-git-bot @amkarthik
[UPD] README.rst
78285cd
@OCA-git-bot @amkarthik
website_google_tag_manager 15.0.2.0.0
a3a47a0
@bvanjeelharia @amkarthik
[IMP] website_google_tag_manager: pre-commit stuff
91cb89a
@bvanjeelharia @amkarthik
[MIG] website_google_tag_manager: Migration to 16.0
11c82a7
@amkarthik
[UPD] Update website_google_tag_manager.pot
1bb64fe
@weblate @amkarthik
Update translation files
26034e1 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/
@francesco-ooops @amkarthik
Translated using Weblate (Italian)
f407e51 
Currently translated at 12.5% (1 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
@OCA-git-bot @amkarthik
[UPD] README.rst
6e160dd
@Ivorra78 @amkarthik
Translated using Weblate (Spanish)
6cfb544 
Currently translated at 100.0% (8 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/es/
@mymage @amkarthik
Translated using Weblate (Italian)
32fd7ca 
Currently translated at 100.0% (8 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
@SodexisTeam @amkarthik
[IMP] website_google_tag_manager: pre-commit auto fixes
6e738f7
@SodexisTeam @amkarthik
[MIG] website_google_tag_manager: Migration to 17.0
6022765
@amkarthik
[UPD] Update website_google_tag_manager.pot
c43b469
@OCA-git-bot @amkarthik
[BOT] post-merge updates
5f62929
@weblate @amkarthik
Update translation files
37832e3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-17.0/website-17.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_google_tag_manager/
@rolandojduartem @amkarthik
[FIX] website_google_tag_manager: fix hidden menu behavior with tag m…
17fdb16 
…anager

Adding script before the wrapwrap element affects style [1] and hide the
nav bar behind of the main menu, so it is required adding it after the
wrapwrap element, the same way as [2] does it.

Reference:

- [1] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/static/src/scss/website.scss#L200
- [2] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/views/website_templates.xml#L151
@OCA-git-bot @amkarthik
[BOT] post-merge updates
64b721a
@amkarthik
[IMP] website_google_tag_manager: pre-commit auto fixes
f38803b
@amkarthik
[MIG] website_google_tag_manager: Migration to 18.0
5ebcf9a
@amkarthik amkarthik force-pushed the 18.0-mig-website_google_tag_manager branch from 580e1de to 5ebcf9a Compare February 4, 2025 06:23
@amkarthik
Copy link
Member

@StefanRijnhart
I triggered "git pull oca 18.0 --rebase" to rebase the commits from oca repo and pushed it to PR branch
I am not sure why it's showing as you mentioned.
Please let me know If I miss something.
I have a backup of PR branch without any modifications in it.

StefanRijnhart
StefanRijnhart approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good now after the latest push!

@StefanRijnhart
Copy link
Member

/ocabot migration website_google_tag_manager

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 4, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 4, 2025
Open
5 tasks
@desdelinux
Copy link

Hi @StefanRijnhart @pedrobaeza this is ready :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@desdelinux desdelinux desdelinux approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.