[FIX] sale_order_type: Incompatibility with l10n_latam_check module #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a work-in-progress PR and is not yet finished. When adding a dependency to the _compute_journal_id method, it breaks the functionality of the l10n_latam_check module when calculating the l10n_latam_check_issuer_vat field during the creation of a third-party check payment. Steps to reproduce: Create a payment. Choose a third-party check journal. Modify the l10n_latam_check_issuer_vat issuer. Save the payment. The l10n_latam_check_issuer_vat field is recomputed.
|
This PR resolve the same error of the PR #3159 |
rov-adhoc
approved these changes
Jan 31, 2025
|
Hi @rousseldenis I see that you analyzed the problem that @rov-adhoc raised in the PR. |
rov-adhoc
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects an error that occurs in the core's l10n_latam_check module when creating third-party checks, when the sale_order_type module is installed.
The error comes up when adding the sale_type_id dependency to the _compute_journal_id method of the account.move model.
While adding the dependency is technically correct, it creates a problem due to the relationship between the account.move and account.payment models, both during the creation of payments from the backend and during import.
The modification proposed in this PR solves the problem in the following ways:
The sale_type_id dependency in _compute_journal_id is removed and replaced by the calculation in _search_default_journal. This avoids the conflict in the relationship between account.move and account.payment.
An onchange is added for the order_type_id field in the form. This ensures that the journal is recalculated correctly when the order type is modified.
It is validated that the journal is present in suitable_journal_ids. This prevents the user from selecting a journal to which they do not have access.
Behavior before the PR
Behavior after the PR