[18.0] [MIG] sale_cancel_reason: Migration to 18.0 #3506

bizzappdev · 2024-12-19T11:49:28Z

No description provided.

(../trunk-generic/ rev 29.1.1)

(../trunk-generic/ rev 32.1.1)

(../trunk-generic/ rev 32.1.2)

- Update travis.yml to 8.0

Only hide button instead of renaming it

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

… of sale_cancel_reason module

* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2

Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/

jbaudoux

LGTM

rconjour

LGTM!

bealdav

LGTM, thanks

bizzappdev · 2025-01-17T08:30:34Z

sale_cancel_reason/view/sale_view.xml

+        <field name="model">sale.order</field>
+        <field name="inherit_id" ref="sale.view_order_form" />
+        <field name="arch" type="xml">
+            <xpath expr="/form/sheet/div/h1" position="after">


I'm not sure I understand properly, but in v17, the field is also not editable. And Look position and behaviour are exactly the same as in v17. PFA v17 and v18 screenshots.
V18

v17

bealdav · 2025-01-17T09:17:33Z

Yes, I guess a migration with the same functionality as the previous feature is enough for now.
@rjaraspearhead, you could add a new feature in a new PR, right?
I propose to merge like that?

Thanks a lot.

rjaraspearhead

LGTM, thanks

celm1990

Please squash administrative commits according this guide
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

celm1990

Tested, LGTM, just a minor changes

celm1990 · 2025-01-17T20:34:47Z

sale_cancel_reason/wizard/cancel_reason_view.xml

+                        sale order.
+                    </p>
+                <group>
+                    <field name="reason_id" widget="selection" />


I prefer this approach instead of using the selection widget. Could you update it? This is better for the UI and allows users to search within the records.

Suggested change

<field name="reason_id" widget="selection" />

<field name="reason_id" options="{'no_create': True, 'no_open': True}" />

sounds a good improvement indeed

celm1990 · 2025-01-17T20:35:06Z

sale_cancel_reason/wizard/mass_cancel_orders_view.xml

+        <field name="arch" type="xml">
+            <footer position="before">
+                <group>
+                    <field name="reason_id" widget="selection" />


the same here

Changes are Done.

bealdav · 2025-01-20T10:57:20Z

@bizzappdev do you think it is possible to update this PR as requested by @celm1990 or do you think it is inappropriate? Thanks

bealdav · 2025-01-22T08:19:10Z

Thanks @bizzappdev

@celm1990 could you approve ?

marcelofrare

LGTM functionally

celm1990

LGTM
@OCA/crm-sales-marketing-maintainers could somebody please review this? , thanks a lot!

simahawk · 2025-01-28T08:48:33Z

/ocabot migration sale_cancel_reason
/ocabot merge nobump

OCA-git-bot · 2025-01-28T08:48:40Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3506-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2025-01-28T08:54:59Z

Congratulations, your PR was merged at a254aba. Thanks a lot for contributing to OCA. ❤️

guewen and others added 30 commits December 17, 2024 16:35

[MRG] from master branch

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

c352220

(../trunk-generic/ rev 29.1.1)

[FIX] sale cancel reason dependence

23d6d19

(../trunk-generic/ rev 32.1.1)

[FIX] sale_cancel_reason: remove dependency on sale_stock

17e407b

(../trunk-generic/ rev 32.1.2)

spellcheck

9a53292

[FIX] repository PEP8

3d1caf4

[FIX] Still some PEP8 erros

a085207

- Set as uninstallable and moved to __unported__ dir all modules.

407ffe6

- Update travis.yml to 8.0

reactivate sale_cancel_reason

63bd52a

port models and method to api 8.0

af09ab6

Improve override of cancel button to ease inheritance of view

4696f50

Only hide button instead of renaming it

[FIX] typo on class name

303ebe8

Add OCA as author of OCA addons

9936be6

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Added Finnish translations

2d2b2d7

[FIX] cancel button of orignal view should be hide after installation…

75e3f5b

… of sale_cancel_reason module

Add missing default oca icons

84c7c96

Slovene translations added

2790791

bump version of sale_cancel_reason

41e5ad3

OCA Transbot updated translations from Transifex

47ab97d

[MIG] Make modules uninstallable

e927156

[FIX] remove en.po that was erroneously created by transbot

b13c86a

[MIG] Rename manifest files

7dfeaa5

[MIG] sale_cancel_reason Migration to 10.0 (OCA#477)

8d30e6e

* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2

remove obsolete .pot files [ci skip]

01aef8b

[UPD] Update sale_cancel_reason.pot

5bd1024

Update translation files

51f4fe9

Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.

Translated using Weblate (Portuguese)

018663d

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/

[MIG] sale_cancel_reason: Migration to 12.0

303538f

[UPD] README.rst

ef788f1

[UPD] Update sale_cancel_reason.pot

7263bd6

Update translation files

a36cdf4

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/

bizzappdev marked this pull request as ready for review December 19, 2024 11:59

jbaudoux approved these changes Dec 30, 2024

View reviewed changes

rconjour approved these changes Jan 6, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 6, 2025

bealdav approved these changes Jan 15, 2025

View reviewed changes

OCA-git-bot removed the approved label Jan 17, 2025

bizzappdev commented Jan 17, 2025

View reviewed changes

rjaraspearhead approved these changes Jan 17, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 17, 2025

celm1990 suggested changes Jan 17, 2025

View reviewed changes

OCA-git-bot removed the approved label Jan 17, 2025

celm1990 suggested changes Jan 17, 2025

View reviewed changes

[MIG] sale_cancel_reason: Migration to 18.0

458def4

bizzappdev force-pushed the 18.0-mig-sale_cancel_reason-BAD branch from fe734e7 to 458def4 Compare January 20, 2025 14:22

marcelsavegnago approved these changes Jan 20, 2025

View reviewed changes

marcelofrare approved these changes Jan 26, 2025

View reviewed changes

celm1990 approved these changes Jan 26, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 26, 2025

OCA-git-bot added this to the 18.0 milestone Jan 28, 2025

OCA-git-bot added the bot is merging ⏳ label Jan 28, 2025

OCA-git-bot mentioned this pull request Jan 28, 2025

Migration to version 18.0 #3344

Open

61 tasks

OCA-git-bot merged commit 7f9dc2d into OCA:18.0 Jan 28, 2025
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0] [MIG] sale_cancel_reason: Migration to 18.0 #3506

[18.0] [MIG] sale_cancel_reason: Migration to 18.0 #3506

bizzappdev commented Dec 19, 2024

jbaudoux left a comment

rconjour left a comment

bealdav left a comment

bizzappdev Jan 17, 2025

bealdav commented Jan 17, 2025

rjaraspearhead left a comment

celm1990 left a comment

celm1990 left a comment

celm1990 Jan 17, 2025

jbaudoux Jan 20, 2025

celm1990 Jan 17, 2025

bizzappdev Jan 20, 2025

bealdav commented Jan 20, 2025

bealdav commented Jan 22, 2025

marcelofrare left a comment

celm1990 left a comment

simahawk commented Jan 28, 2025

OCA-git-bot commented Jan 28, 2025

OCA-git-bot commented Jan 28, 2025

	<field name="reason_id" widget="selection" />
	<field name="reason_id" options="{'no_create': True, 'no_open': True}" />

[18.0] [MIG] sale_cancel_reason: Migration to 18.0 #3506

[18.0] [MIG] sale_cancel_reason: Migration to 18.0 #3506

Conversation

bizzappdev commented Dec 19, 2024

jbaudoux left a comment

Choose a reason for hiding this comment

rconjour left a comment

Choose a reason for hiding this comment

bealdav left a comment

Choose a reason for hiding this comment

bizzappdev Jan 17, 2025

Choose a reason for hiding this comment

bealdav commented Jan 17, 2025

rjaraspearhead left a comment

Choose a reason for hiding this comment

celm1990 left a comment

Choose a reason for hiding this comment

celm1990 left a comment

Choose a reason for hiding this comment

celm1990 Jan 17, 2025

Choose a reason for hiding this comment

jbaudoux Jan 20, 2025

Choose a reason for hiding this comment

celm1990 Jan 17, 2025

Choose a reason for hiding this comment

bizzappdev Jan 20, 2025

Choose a reason for hiding this comment

bealdav commented Jan 20, 2025

bealdav commented Jan 22, 2025

marcelofrare left a comment

Choose a reason for hiding this comment

celm1990 left a comment

Choose a reason for hiding this comment

simahawk commented Jan 28, 2025

OCA-git-bot commented Jan 28, 2025

OCA-git-bot commented Jan 28, 2025