Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0] [MIG] sale_order_line_menu: Migration to 18.0 #3470

Merged
merged 17 commits into from
Jan 29, 2025
Merged

[18.0] [MIG] sale_order_line_menu: Migration to 18.0 #3470

merged 17 commits into from
Jan 29, 2025

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Dec 7, 2024

Migration from 17.0 to 18.0

Issue: #3344

Freni-OSI and others added 16 commits December 7, 2024 15:31
@Freni-OSI @Borruso
[14.0][ADD]Added Module sale_order_line_menu
80ace7f
@Yvesldff @Borruso
Added translation using Weblate (French (France)), (Spanish), (Franch…
3427d84 
… (Belgium))

Translated using Weblate (French (France))

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr_FR/

Added translation using Weblate (Spanish)

Translated using Weblate (Spanish)

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/es/

Added translation using Weblate (French (Belgium))

Added translation using Weblate (French)

Translated using Weblate (French)

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr/
@RLeeOSI @Borruso
[MIG] sale_order_line_menu: Migration to 15.0
4b997a2
@Murtaza-OSI @Borruso
[16.0][MIG] sale_order_line_menu
ee0b662
@badbole @Borruso
Added translation using Weblate (Croatian)
7092973
@dalonsofl @Borruso
[16.0][IMP]sale_order_line_menu: set no visible sections and notes in…
befebf8 
… sale order lines menu
@dalonsofl @Borruso
[16.0][IMP]sale_order_line_menu: set no visible sale order line menu …
3a178e3 
…if you do not have any Sales permission
@EmilioPascual @Borruso
[16.0][IMP] sale_order_line_menu: New views and stored fields
afca418 
New views and fields added to the sale_order_line_menu

MT-2028 @moduon @rafaelbn @dreispt @Shide @fcvalgar please review
@Ivorra78 @Borruso
Translated using Weblate (Spanish)
9dba915 
Currently translated at 100.0% (19 of 19 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_menu/es/
@sbidoul @Borruso
Convert sale_order_line_menu readme fragments to markdown
13d9e60
@adrianojprado @Borruso
Added translation using Weblate (Portuguese (Brazil))
c263703
@jappi00 @Borruso
Added translation using Weblate (German)
3f8cf9e
@mymage @Borruso
Added translation using Weblate (Italian)
3224779
@Borruso
[IMP] sale_order_line_menu: black, isort, prettier
b7e0137
@Borruso
[MIG] sale_order_line_menu: Migration to 17.0
befcf5c
@Borruso
[IMP] sale_order_line_menu: pre-commit auto fixes
8ff0579
@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 2 times, most recently from 51a7f4c to 414a138 Compare December 7, 2024 15:20
@Naraka
Copy link

Naraka commented Dec 9, 2024

If you try to create a new order line within the form of an existing order line, it throws an error.

Captura desde 2024-12-09 17-05-02

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_line_menu

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 10, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 10, 2024
Open
61 tasks
sheragar
sheragar approved these changes Dec 11, 2024
View reviewed changes
Copy link

@sheragar sheragar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Funtional Review 👍

@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 2 times, most recently from 77878fb to 96bf699 Compare December 12, 2024 14:32
@Borruso
Copy link
Contributor Author

Borruso commented Dec 12, 2024

If you try to create a new order line within the form of an existing order line, it throws an error.

Captura desde 2024-12-09 17-05-02

Can you check again?

Naraka
Naraka approved these changes Dec 13, 2024
View reviewed changes
Copy link

@Naraka Naraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Shide
Shide approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

PieterPaulussen
PieterPaulussen suggested changes Jan 7, 2025
View reviewed changes
@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch from 96bf699 to 7f8fa7a Compare January 10, 2025 09:35
@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 3 times, most recently from c8a0606 to fdbf560 Compare January 13, 2025 08:54
@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch from fdbf560 to c7bde69 Compare January 13, 2025 09:01
PieterPaulussen
PieterPaulussen approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@PieterPaulussen PieterPaulussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes regarding my feedback. There are indeed other issues that need to be addressed in a different PR. But this will suffice for now. THanks.

@joepsanders
Copy link

@PieterPaulussen is this PR ready for merging? What other issues need to be addressed? Could you point that PR? Thanks!

@PieterPaulussen
Copy link
Contributor

@joepsanders The PR has 4 approvals, including mine. I thinks it's safe to merge.

@pedrobaeza
Copy link
Member

Technically, a PSC should review it, no matter the number of approvals, but I see some respected contributors that have approved already, so merging:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3470-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 75da61d into OCA:18.0 Jan 29, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 95a65c1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shide Shide Shide approved these changes

@PieterPaulussen PieterPaulussen PieterPaulussen approved these changes

@Naraka Naraka Naraka approved these changes

@sheragar sheragar sheragar approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.