Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] sale_order_line_date: fix setting empty commitment date on stock moves #3364

Conversation

metaminux
Copy link
Contributor

…sale order line

Closes #3363

@metaminux
Copy link
Contributor Author

First commit is a test confirming issue #3363
Second one is my attempt to fix it.

@ferran-S73 @rousseldenis @Kev-Roche Ready for your reviews...

Regards,

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just closed duplicate #3540 of this one.

@StefanRijnhart StefanRijnhart changed the title [ADD] sale_order_line_date : add test for commitment date removal on … [18.0][ADD] sale_order_line_date : add test for commitment date removal on … Feb 3, 2025
@StefanRijnhart StefanRijnhart changed the title [18.0][ADD] sale_order_line_date : add test for commitment date removal on … [18.0][FIX] sale_order_line_date: fix setting empty commitment date on stock moves Feb 3, 2025
@StefanRijnhart StefanRijnhart changed the title [18.0][FIX] sale_order_line_date: fix setting empty commitment date on stock moves [16.0][FIX] sale_order_line_date: fix setting empty commitment date on stock moves Feb 3, 2025
@StefanRijnhart
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3364-by-StefanRijnhart-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b36c769 into OCA:16.0 Feb 3, 2025
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7e4fc40. Thanks a lot for contributing to OCA. ❤️

@StefanRijnhart
Copy link
Member

Porting to 18.0 in #3565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[16.0] sale_order_line_date : removing the date after sale has been confirmed raises TypeError
4 participants