Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] report_qweb_parameter: Migration to 17.0 #816

Merged
merged 12 commits into from
Dec 9, 2023
Merged

[17.0][MIG] report_qweb_parameter: Migration to 17.0 #816

merged 12 commits into from
Dec 9, 2023

Conversation

ramiadavid
Copy link
Contributor

No description provided.

etobella and others added 11 commits November 18, 2023 09:09
@etobella @ramiadavid
[ADD] report_field_length
618f2ff
@etobella @ramiadavid
[MIG] report_qweb_parameter: Migration to 11.0
c33c6e0
@EfrenTM @ramiadavid
[MIG] report_qweb_parameter: Migration to 12.0
351250c
@pedrobaeza @ramiadavid
[IMP] report_qweb_parameter: Avoid error on integration tests
0b8cfdc 
If reusing existing records, there's the risk of conflicting tests, like modifying
the VAT for the existing company and that company having a country with VAT check.

We avoid it creating a new company instead.
@CarlosRoca13 @ramiadavid
[IMP] report_qweb_parameter: black, isort, prettier
de6c4e3
@CarlosRoca13 @ramiadavid
[MIG] report_qweb_parameter: Migration to v13
96f7091
@ozono @ramiadavid
[IMP] report_qweb_parameter: black, isort, prettier
6a09d23
@ozono @ramiadavid
[MIG] report_qweb_parameter: Migration to 14.0
3cdaa82
@AlexanderAcysos @ramiadavid
[MIG] report_qweb_parameter: Migration to 15.0
41fcda2
@ramiadavid
[MIG] report_qweb_parameter: Migration to 16.0
bd9f0a1
@ramiadavid
[IMP] report_qweb_parameter: pre-commit auto fixes
a6ec9d9
@ramiadavid ramiadavid mentioned this pull request Nov 18, 2023
Open
25 tasks
@ramiadavid ramiadavid force-pushed the 17.0-mig-report_qweb_parameter branch from 94057c6 to 12cd40f Compare November 18, 2023 08:53
@ramiadavid
Copy link
Contributor Author

@OCA/community-maintainers Tests and runboat are not working in this repository

@dreispt
Copy link
Member

dreispt commented Nov 18, 2023

The manifest version needs to be changed to 17.0.
Don't remove the utf8 encoding tag from the XML file please.

@ramiadavid ramiadavid force-pushed the 17.0-mig-report_qweb_parameter branch from 12cd40f to 319cb5c Compare November 18, 2023 20:21
@ramiadavid
Copy link
Contributor Author

@dreispt
It's true that I missed the version change, but didn't this warn pre-commit previously?
utf8 encoding tag is deprecated in v17

DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, can just have a UTF8 description with not need for a declaration.

@ramiadavid ramiadavid force-pushed the 17.0-mig-report_qweb_parameter branch from 319cb5c to e85d934 Compare November 18, 2023 20:33
@ramiadavid
Copy link
Contributor Author

@dreispt Sorry, I didn't understand it well, it's only for HTML, not XML, I've already added it again.

@ramiadavid ramiadavid marked this pull request as ready for review November 24, 2023 19:35
@gurneyalex
Copy link
Member

/ocabot migration report_qweb_parameter

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 8, 2023
@dreispt
Copy link
Member

dreispt commented Dec 9, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-816-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4d0af46 into OCA:17.0 Dec 9, 2023
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9c9a7e4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
10 participants
@ramiadavid @dreispt @gurneyalex @OCA-git-bot @etobella @EfrenTM @pedrobaeza @CarlosRoca13 @ozono @AlexanderAcysos