Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX][bi_sql_editor] unlink bi_sql_view without cron #811

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

leemannd
Copy link
Contributor

@leemannd leemannd commented Nov 14, 2023

It isn't possible to unlink a bi sql view if there isn't a CRON related to it.
A fix has been done in 16.0: #770

But letting the ORM handling the unlink doesn't require the line of code.

@PierrickBrun @legalsylvain A review is welcome

It wasn't possible to unlink him.
A fix has been done in 16.0: OCA#770

But letting the ORM handling him doesn't require the line of code
@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@leemannd leemannd changed the title [FIX][bi_sql_editor] unlink bi_sql_view without cron [15.0][FIX][bi_sql_editor] unlink bi_sql_view without cron Nov 14, 2023
Copy link

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leemannd added a commit to leemannd/reporting-engine that referenced this pull request Nov 14, 2023
@dreispt
Copy link
Member

dreispt commented Nov 18, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-811-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cf25353 into OCA:15.0 Nov 18, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 43ed3e1. Thanks a lot for contributing to OCA. ❤️

nguyenminhchien pushed a commit to nguyenminhchien/reporting-engine that referenced this pull request Dec 18, 2023
bealdav pushed a commit to akretion/reporting-engine that referenced this pull request May 31, 2024
sanderlienaerts pushed a commit to codeforward-bv/reporting-engine that referenced this pull request Aug 13, 2024
thienvh332 pushed a commit to thienvh332/reporting-engine that referenced this pull request Oct 2, 2024
thienvh332 pushed a commit to thienvh332/reporting-engine that referenced this pull request Oct 10, 2024
thienvh332 pushed a commit to thienvh332/reporting-engine that referenced this pull request Oct 24, 2024
thienvh332 pushed a commit to thienvh332/reporting-engine that referenced this pull request Nov 29, 2024
adhoc-cicd-bot pushed a commit to adhoc-cicd/oca-reporting-engine that referenced this pull request Jan 13, 2025
adhoc-cicd-bot pushed a commit to adhoc-cicd/oca-reporting-engine that referenced this pull request Jan 20, 2025
adhoc-cicd-bot pushed a commit to adhoc-cicd/oca-reporting-engine that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants