Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrateAddon: rework generation of tips #65

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

sebalix
Copy link
Collaborator

@sebalix sebalix commented Dec 20, 2024

No description provided.

@sebalix sebalix added this to the 0.18 milestone Dec 20, 2024
@sebalix
Copy link
Collaborator Author

sebalix commented Dec 20, 2024

cc @trisdoan

@sebalix sebalix marked this pull request as ready for review December 20, 2024 16:02
}
MIG_USUAL_STEPS = ("reduce_commits", "adapt_module", "commands", "create_pr")
MIG_BLACKLIST_STEPS = ("push_blacklist", "create_pr")
MIG_ADAPTED_STEPS = ("reduce_commits", "adapt_module", "amend_mig_commit", "create_pr")
Copy link
Collaborator Author

@sebalix sebalix Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIG_ADAPTED_STEPS are replacing the SIMPLIFIED_MIG_TIPS and here is added the adapt_module step (and amend_mig_commit) as we cannot say that the job done by odoo-module-migrator is enough to migrate the module, it's only a helper to spare time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a nice work 👍

@sebalix sebalix merged commit 539417e into OCA:main Dec 24, 2024
5 checks passed
@sebalix sebalix deleted the ref-mig-tips branch December 24, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants