[FIX] account_invoice_margin: avoid traceback in invoice #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an invoice, associating a product
(the uom is associated), deleting the product from the
line and saving, an error is obtained:
File
"/home/odoo/src/user/margin-analysis/account_invoice_margin/models/account_invoice.py",
line 108, in _compute_purchase_price
purchase_price = line.product_id.uom_id._compute_price(
File "/home/odoo/src/odoo/addons/uom/models/uom_uom.py", line 247, in
_compute_price
self.ensure_one()
File "/home/odoo/src/odoo/odoo/models.py", line 5243, in ensure_one
raise ValueError("Expected singleton: %s" % self)
This is because it attempts to take the uom of the
product to calculate the purchase price and the
product is empty.
The product is validated before performing the
calculation, to avoid the error.
|
Hi @sergio-teruel, |
|
Hi @moylop260 could you check this, please? |
sergio-teruel
approved these changes
Nov 6, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 76042f8. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an invoice, associating a product (the uom is associated), deleting the product from the line and saving, an error is obtained:
This is because it attempts to use the product's uom to calculate the purchase price, and the product is empty.
The product is validated before performing the calculation, to avoid the error.
Functional test before the fix
https://youtu.be/ZbEGpCJR-xI
Functional test after the fix
https://youtu.be/W2pW2myxQU8