[16.0][FW-PORT][IMP] sale_margin_security: Avoid display margin in measures pivot view. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set group_sale_margin_security in all sensible fields.
|
Hi @sergio-teruel, |
|
Please mention the PR that this is a fw-port of. This helps to speed up reviews. |
ValentinVinagre
changed the title
done 😄 |
HaraldPanten
approved these changes
Dec 22, 2023
pedrobaeza
approved these changes
Dec 22, 2023
|
This PR looks fantastic, let's merge it! |
For the next few times I will keep it in mind, I didn't know how it was managed :) thanks Pedro. |
|
Congratulations, your PR was merged at 60da0d8. Thanks a lot for contributing to OCA. ❤️ |
HaraldPanten
deleted the
16.0-IMP-sale_margin_security-avoid_margin_pivot_view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #188
Set group_sale_margin_security in all sensible fields.